-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Backport #5275 to release-1.6 #5559
Conversation
Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## release-1.6 #5559 +/- ##
===============================================
- Coverage 61.60% 57.09% -4.52%
===============================================
Files 304 304
Lines 33409 33409
===============================================
- Hits 20582 19075 -1507
- Misses 10041 11765 +1724
+ Partials 2786 2569 -217
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@wonderflow @chivalryq There will be some conflicts in unit tests. Is it okay to resolve these conflicts?Will it affect its original function? |
@suwliang3 Good job. You can try to solve the conflicts. I guess most of them won't affect the function. They are just API incompatibility caused by version bumping. |
Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
Check-diff job failed because the controller-gen version in CI is bumped. Please run |
Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why there're so many changes while #5275 only changes 6 lines.
It should be the reason for the package version dependency. @chivalryq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. cc @wonderflow I checked the changes and most of them is introduced by bumping version of tools like controller-gen
and dependency in pkg repo. It's OK to merge this.
Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
ping @wonderflow |
Description of your changes
Update pkg dependency, refer to kubevela/pkg#28 #5275
Fixes #5556
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer