Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the array type cannot be converted to interface type #5578

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

nuclearwu
Copy link
Contributor

@nuclearwu nuclearwu commented Feb 27, 2023

Signed-off-by: wuzhongjian wuzhongjian_yewu@cmss.chinamobile.com

Description of your changes

Fixes #5564

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
@nuclearwu
Copy link
Contributor Author

@barnettZQG

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch coverage: 57.89% and project coverage change: +3.38 🎉

Comparison is base (af10f11) 46.50% compared to head (1917557) 49.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5578      +/-   ##
==========================================
+ Coverage   46.50%   49.88%   +3.38%     
==========================================
  Files         308      310       +2     
  Lines       47795    47930     +135     
==========================================
+ Hits        22226    23911    +1685     
+ Misses      22781    21508    -1273     
+ Partials     2788     2511     -277     
Flag Coverage Δ
apiserver-e2etests ?
apiserver-unittests 36.32% <57.89%> (+0.05%) ⬆️
core-unittests 55.71% <ø> (?)
e2e-multicluster-test 19.05% <0.00%> (+0.03%) ⬆️
e2e-rollout-tests 21.47% <ø> (+0.09%) ⬆️
e2etests 26.91% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/service/util.go 78.43% <57.89%> (-4.43%) ⬇️
...kg/apiserver/interfaces/api/assembler/v1/do2dto.go 0.00% <0.00%> (-91.67%) ⬇️
pkg/apiserver/domain/service/service.go 0.00% <0.00%> (-91.43%) ⬇️
...kg/apiserver/interfaces/api/assembler/v1/dto2do.go 0.00% <0.00%> (-87.50%) ⬇️
pkg/apiserver/domain/model/workflow.go 12.96% <0.00%> (-87.04%) ⬇️
pkg/apiserver/interfaces/api/velaql.go 5.71% <0.00%> (-82.86%) ⬇️
pkg/apiserver/domain/model/cluster.go 17.39% <0.00%> (-82.61%) ⬇️
pkg/apiserver/event/sync/convert/convert.go 0.00% <0.00%> (-82.15%) ⬇️
pkg/apiserver/domain/model/env.go 20.00% <0.00%> (-80.00%) ⬇️
pkg/apiserver/domain/model/application.go 9.23% <0.00%> (-77.70%) ⬇️
... and 223 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests?

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
@nuclearwu
Copy link
Contributor Author

Can you add some tests?

ok, done, please review again @FogDong

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
@nuclearwu
Copy link
Contributor Author

@barnettZQG @FogDong

@barnettZQG barnettZQG added the backport release-1.7 add this label will automatically backport this PR to release-1.7 branch label Mar 1, 2023
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Successfully created backport PR for release-1.7:

@nuclearwu
Copy link
Contributor Author

LGTM

Is it necessary to backport 1.6.x ? @barnettZQG

@barnettZQG barnettZQG added the backport release-1.6 add this label will automatically backport this PR to release-1.6 branch label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.6 add this label will automatically backport this PR to release-1.6 branch backport release-1.7 add this label will automatically backport this PR to release-1.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]Failed to query policy details generated by application
3 participants