-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: the array type cannot be converted to interface type #5578
Conversation
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5578 +/- ##
==========================================
+ Coverage 46.50% 49.88% +3.38%
==========================================
Files 308 310 +2
Lines 47795 47930 +135
==========================================
+ Hits 22226 23911 +1685
+ Misses 22781 21508 -1273
+ Partials 2788 2511 -277
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests?
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
ok, done, please review again @FogDong |
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Successfully created backport PR for |
Is it necessary to backport 1.6.x ? @barnettZQG |
Signed-off-by: wuzhongjian wuzhongjian_yewu@cmss.chinamobile.com
Description of your changes
Fixes #5564
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer