Feat: remove loop reduction & filter unnecessary apprev update #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
requested review from
FogDong,
barnettZQG,
wonderflow,
leejanee and
jefree-cat
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5598 +/- ##
==========================================
- Coverage 61.55% 57.53% -4.02%
==========================================
Files 311 311
Lines 48021 48018 -3
==========================================
- Hits 29557 27629 -1928
- Misses 15406 17503 +2097
+ Partials 3058 2886 -172
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Somefive
force-pushed
the
feat/remove-loop-reduction
branch
from
669f0c0
to
23b4f64
Compare
wonderflow
reviewed
Mar 3, 2023
| @@ -856,6 +856,9 @@ func (h *AppHandler) FinalizeAndApplyAppRevision(ctx context.Context) error { | |||
| } | |||
| return err | |||
| } | |||
| if apiequality.Semantic.DeepEqual(gotAppRev.Spec, appRev.Spec) { | |||
There was a problem hiding this comment.
please also compare the annotations and labels from metadata
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
feat/remove-loop-reduction
branch
from
23b4f64
to
9fa6465
Compare
wonderflow
approved these changes
Mar 3, 2023
FogDong
approved these changes
Mar 3, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add two optimization:
loop-reductionoptimization and let it be enabled by default. This is because the workflow state transition has changed its mechanism and if we do not enable loop reduction by default, the application will run twice gc every reconcile.Result:
Optimization 1 can reduce the reconcile time from 125ms to 96ms, increase 23% performance for state-keep-oriented reconcile under simple application delivery scenario.
Optimization 2 can reduce the reconcile time from 96ms to 70ms, increase 27% performance for state-keep oriented reconcile under simple application delivery scenario.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer