Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: sync sdk automatically #5630

Merged
merged 6 commits into from
Mar 9, 2023
Merged

Feat: sync sdk automatically #5630

merged 6 commits into from
Mar 9, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented Mar 8, 2023

Description of your changes

  1. Sync SDK to https://github.com/kubevela-contrib/kubevela-go-sdk when
    1. SDK generating logic is changed
    2. Any Built-in Definition is changed.
  2. Add ToJSON method to application.
  3. Modify SDK readme.

I have:

  • Read and followed KubeVela's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

The sync has been tested

image

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: +17.31 🎉

Comparison is base (3f53c26) 44.37% compared to head (6c86ba3) 61.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5630       +/-   ##
===========================================
+ Coverage   44.37%   61.69%   +17.31%     
===========================================
  Files         299      313       +14     
  Lines       46612    48137     +1525     
===========================================
+ Hits        20686    29697     +9011     
+ Misses      23288    15371     -7917     
- Partials     2638     3069      +431     
Flag Coverage Δ
apiserver-e2etests 35.96% <ø> (+0.11%) ⬆️
apiserver-unittests 36.34% <ø> (+0.01%) ⬆️
core-unittests 55.65% <ø> (?)
e2e-multicluster-test 25.63% <ø> (?)
e2e-rollout-tests 22.01% <ø> (+0.40%) ⬆️
e2etests 27.71% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/domain/service/authentication.go 48.25% <0.00%> (-0.59%) ⬇️
pkg/apiserver/event/sync/cache.go 68.00% <0.00%> (ø)
pkg/velaql/providers/query/handler.go 58.08% <0.00%> (ø)
pkg/apiserver/domain/service/velaql.go 55.26% <0.00%> (ø)
pkg/apiserver/domain/model/application.go 86.92% <0.00%> (ø)
pkg/apiserver/domain/service/cloudshell.go 62.58% <0.00%> (ø)
pkg/apiserver/domain/service/definition.go 73.31% <0.00%> (ø)
pkg/apiserver/domain/service/envbinding.go 45.91% <0.00%> (ø)
pkg/apiserver/utils/ui_schema.go
pkg/cmd/factory.go 69.23% <0.00%> (ø)
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

fix sdk test

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chivalryq chivalryq merged commit 07a05c4 into master Mar 9, 2023
@wonderflow wonderflow deleted the feat/sync-sdk branch March 9, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants