Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add addon registry #5646

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Fix: add addon registry #5646

merged 2 commits into from
Mar 13, 2023

Conversation

suwliang3
Copy link
Contributor

Description of your changes

Fixes #5645

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

replace token with gitToken
vela addon registry add my-repo --type git --endpoint=https://git --path=experimental/addons --gitToken=ghp_T3

Special notes for your reviewer

Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.58 🎉

Comparison is base (6704e97) 59.91% compared to head (6ae828c) 61.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5646      +/-   ##
==========================================
+ Coverage   59.91%   61.49%   +1.58%     
==========================================
  Files         308      313       +5     
  Lines       47923    48137     +214     
==========================================
+ Hits        28714    29603     +889     
+ Misses      16212    15474     -738     
- Partials     2997     3060      +63     
Flag Coverage Δ
apiserver-e2etests 35.89% <ø> (-0.02%) ⬇️
apiserver-unittests 36.34% <ø> (ø)
core-unittests 55.64% <ø> (-0.06%) ⬇️
e2e-multicluster-test 25.52% <ø> (?)
e2e-rollout-tests 22.05% <ø> (+0.08%) ⬆️
e2etests 27.36% <ø> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 60 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
Copy link
Collaborator

@wangyikewxgm wangyikewxgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@wangyikewxgm wangyikewxgm added the backport release-1.7 add this label will automatically backport this PR to release-1.7 branch label Mar 13, 2023
@Somefive Somefive merged commit 54311b9 into kubevela:master Mar 13, 2023
@github-actions
Copy link

Successfully created backport PR for release-1.7:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.7 add this label will automatically backport this PR to release-1.7 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] add addon registry failed
4 participants