Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.6] Fix: stores workflow status in revison if it is restarted (#5604) #5672

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Mar 14, 2023

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (4bbd6c3) 61.66% compared to head (ca78c15) 61.65%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.6    #5672      +/-   ##
===============================================
- Coverage        61.66%   61.65%   -0.02%     
===============================================
  Files              304      304              
  Lines            33409    33413       +4     
===============================================
- Hits             20603    20600       -3     
+ Misses           10028    10023       -5     
- Partials          2778     2790      +12     
Flag Coverage Δ
apiserver-e2etests 35.75% <ø> (+0.03%) ⬆️
apiserver-unittests 37.24% <ø> (+0.02%) ⬆️
core-unittests 55.27% <100.00%> (-0.05%) ⬇️
e2e-multicluster-test 18.80% <100.00%> (+0.02%) ⬆️
e2e-rollout-tests 20.25% <100.00%> (+0.03%) ⬆️
e2etests 25.84% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dev/v1alpha2/application/application_controller.go 85.75% <100.00%> (-2.50%) ⬇️
...ler/core.oam.dev/v1alpha2/application/generator.go 88.21% <100.00%> (+0.25%) ⬆️
...ller/core.oam.dev/v1alpha2/application/revision.go 72.66% <100.00%> (-0.37%) ⬇️

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

)

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong merged commit b7683eb into kubevela:release-1.6 Mar 14, 2023
@FogDong FogDong deleted the release-1.6 branch March 14, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants