Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: option pattern #5720

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Refactor: option pattern #5720

merged 2 commits into from
Mar 24, 2023

Conversation

iyear
Copy link
Contributor

@iyear iyear commented Mar 22, 2023

Description of your changes

Part of #5364

  • Refactor registry to option pattern
  • Support different options for each generation

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Unit tests

Special notes for your reviewer

@iyear
Refactor: option pattern
ffb8c1d 
Signed-off-by: iyear <ljyngup@gmail.com>
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 22, 2023 •
edited

Codecov Report

Patch coverage has no change and project coverage change: -5.85 ⚠️

Comparison is base (6976b2b) 61.53% compared to head (db82324) 55.69%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5720      +/-   ##
==========================================
- Coverage   61.53%   55.69%   -5.85%     
==========================================
  Files         217      212       -5     
  Lines       30582    30368     -214     
==========================================
- Hits        18820    16914    -1906     
- Misses      10036    11833    +1797     
+ Partials     1726     1621     -105
Flag Coverage Δ
core-unittests 55.70% <ø> (-0.06%) ⬇️
e2e-multicluster-test ?
e2e-rollout-tests 22.36% <ø> (-0.05%) ⬇️
e2etests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 73 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iyear
Fix: nil check and add tests
db82324 
Signed-off-by: iyear <ljyngup@gmail.com>
@iyear
Copy link
Contributor Author

iyear commented Mar 22, 2023

Unit test failed in references/docgen and I try to re-run CI

@iyear
Copy link
Contributor Author

iyear commented Mar 24, 2023 •
edited

Hi, any update?

@Somefive Somefive merged commit d694dff into kubevela:master Mar 24, 2023
@iyear iyear mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Somefive Somefive Somefive approved these changes

@FogDong FogDong FogDong approved these changes

@barnettZQG barnettZQG Awaiting requested review from barnettZQG barnettZQG is a code owner

@wonderflow wonderflow Awaiting requested review from wonderflow wonderflow is a code owner

@leejanee leejanee Awaiting requested review from leejanee leejanee is a code owner

@jefree-cat jefree-cat Awaiting requested review from jefree-cat jefree-cat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iyear @Somefive @FogDong