Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support pause reconcile #5732

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Mar 24, 2023

Description of your changes

Fixes #5723

Usage:

Add label controller.core.oam.dev/pause: "true" to application will let it be ignored by the controller. Once the label value is not "true" or be removed, it will be reconciled again.

apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  name: busybox
  labels:
    controller.core.oam.dev/pause: "true"
spec:
  components:
    - name: data-worker
      type: worker
      properties:
        image: busybox
        cmd:
          - sleep
          - '1000000'

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found 5 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (80da131) 61.71% compared to head (08e9e69) 61.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5732      +/-   ##
==========================================
- Coverage   61.71%   61.70%   -0.02%     
==========================================
  Files         217      217              
  Lines       30582    30736     +154     
==========================================
+ Hits        18875    18965      +90     
- Misses       9991    10039      +48     
- Partials     1716     1732      +16     
Flag Coverage Δ
core-unittests 55.81% <0.00%> (-0.06%) ⬇️
e2e-multicluster-test 25.79% <100.00%> (+<0.01%) ⬆️
e2e-rollout-tests 22.37% <0.00%> (-0.06%) ⬇️
e2etests 28.12% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dev/v1alpha2/application/application_controller.go 85.77% <100.00%> (+0.06%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit 4aa14fc into kubevela:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support skip reconcile application
2 participants