Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: gateway message is wrong #5748

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

chivalryq
Copy link
Member

Description of your changes

gateway message is wrong. "host" is always now.

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq added backport release-1.7 add this label will automatically backport this PR to release-1.7 branch backport release-1.8 add this label will automatically backport this PR to release-1.8 branch labels Mar 27, 2023
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found 5 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -36.00 ⚠️

Comparison is base (1afdb09) 61.66% compared to head (23ac69a) 25.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5748       +/-   ##
===========================================
- Coverage   61.66%   25.66%   -36.00%     
===========================================
  Files         217      214        -3     
  Lines       30717    30582      -135     
===========================================
- Hits        18941     7850    -11091     
- Misses      10037    21679    +11642     
+ Partials     1739     1053      -686     
Flag Coverage Δ
core-unittests ?
e2e-multicluster-test 25.60% <ø> (-0.03%) ⬇️
e2e-rollout-tests 22.39% <ø> (+0.04%) ⬆️
e2etests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 158 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit 2e109dd into kubevela:master Mar 27, 2023
@github-actions
Copy link

Successfully created backport PR for release-1.7:

@github-actions
Copy link

Successfully created backport PR for release-1.8:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.7 add this label will automatically backport this PR to release-1.7 branch backport release-1.8 add this label will automatically backport this PR to release-1.8 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants