Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: list addon with specify registry #5780

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

zhaohuiweixiao
Copy link
Contributor

@zhaohuiweixiao zhaohuiweixiao commented Mar 30, 2023

Description of your changes

add list addon with specify registry.
when there are multiple registry, vela addon ls command merges the addon's occures in multiple registry. Thus, we can not list all addon in specify registry.

for exampla:
in kubevela and testzhh registry, there are both fluxcd/rollout/vegeta
image
vela addon ls commond only displays the fluxcd/rollout/vege addon in kubevela registry.
image

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

  1. add testzhh registry to addon
  2. push fluxcd/rollout/vegeta addon to testzhh registry
  3. run command vela addon ls

Special notes for your reviewer

@wangyikewxgm

Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com>
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (784106c) 61.58% compared to head (ee2a633) 61.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5780      +/-   ##
==========================================
- Coverage   61.58%   61.54%   -0.04%     
==========================================
  Files         217      217              
  Lines       30694    30694              
==========================================
- Hits        18903    18892      -11     
- Misses      10051    10066      +15     
+ Partials     1740     1736       -4     
Flag Coverage Δ
core-unittests 55.85% <ø> (+0.06%) ⬆️
e2e-multicluster-test 25.64% <ø> (-0.06%) ⬇️
e2e-rollout-tests 22.27% <ø> (-0.02%) ⬇️
e2etests 27.86% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com>
Copy link
Member

@charlie0129 charlie0129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants