Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: expose trait with new ports #5781

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

wonderflow
Copy link
Collaborator

@wonderflow wonderflow commented Mar 31, 2023

Description of your changes

  • update expose trait to support multiple traits and more fields.
  • support matchLabels as an optional fields.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11 ⚠️

Comparison is base (d4576db) 61.68% compared to head (cbe80c5) 61.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5781      +/-   ##
==========================================
- Coverage   61.68%   61.58%   -0.11%     
==========================================
  Files         217      217              
  Lines       30694    30694              
==========================================
- Hits        18935    18904      -31     
- Misses      10023    10050      +27     
- Partials     1736     1740       +4     
Flag Coverage Δ
core-unittests 55.83% <ø> (-0.05%) ⬇️
e2e-multicluster-test 25.63% <ø> (+<0.01%) ⬆️
e2e-rollout-tests 22.27% <ø> (-0.06%) ⬇️
e2etests 28.00% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jianbo Sun <jianbo.sjb@alibaba-inc.com>
@wonderflow wonderflow added the backport release-1.8 add this label will automatically backport this PR to release-1.8 branch label Mar 31, 2023
@github-actions
Copy link

Successfully created backport PR for release-1.8:

@wonderflow wonderflow deleted the exposeport branch March 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.8 add this label will automatically backport this PR to release-1.8 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants