Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: filter rollout created by rolling-release in vela workflow resume #5783

Merged
merged 5 commits into from
Apr 3, 2023

Conversation

wangyikewxgm
Copy link
Collaborator

@wangyikewxgm wangyikewxgm commented Mar 31, 2023

PR provides a rolling-release trait for using Kruise-rollout in workflow. However, our vela workflow resume command currently resumes both the app workflow and the rollout under the app. This PR filters out the rollout resources created by the rolling-release trait.

Description of your changes

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository Security tab to see all alerts.

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (784106c) 61.58% compared to head (b350700) 61.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5783      +/-   ##
==========================================
+ Coverage   61.58%   61.64%   +0.05%     
==========================================
  Files         217      217              
  Lines       30694    30711      +17     
==========================================
+ Hits        18903    18931      +28     
+ Misses      10051    10041      -10     
+ Partials     1740     1739       -1     
Flag Coverage Δ
core-unittests 55.91% <100.00%> (+0.11%) ⬆️
e2e-multicluster-test 25.62% <0.00%> (-0.08%) ⬇️
e2e-rollout-tests 22.29% <ø> (+<0.01%) ⬆️
e2etests 27.96% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/rollout/rollout.go 48.48% <100.00%> (+0.79%) ⬆️

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@wangyikewxgm wangyikewxgm added the backport release-1.8 add this label will automatically backport this PR to release-1.8 branch label Mar 31, 2023
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Copy link
Collaborator

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
@Somefive Somefive merged commit 52b1f20 into kubevela:master Apr 3, 2023
27 checks passed
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.8 add this label will automatically backport this PR to release-1.8 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants