-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: filter rollout created by rolling-release in vela workflow resume
#5783
Fix: filter rollout created by rolling-release in vela workflow resume
#5783
Conversation
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
You have successfully added a new Trivy configuration |
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5783 +/- ##
==========================================
+ Coverage 61.58% 61.64% +0.05%
==========================================
Files 217 217
Lines 30694 30711 +17
==========================================
+ Hits 18903 18931 +28
+ Misses 10051 10041 -10
+ Partials 1740 1739 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Signed-off-by: 楚岳 <wangyike.wyk@alibaba-inc.com>
Successfully created backport PR for |
PR provides a rolling-release trait for using Kruise-rollout in workflow. However, our
vela workflow resume
command currently resumes both the app workflow and the rollout under the app. This PR filters out the rollout resources created by the rolling-release trait.Description of your changes
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer