Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: vela cluster join support overwrite #5784

Merged

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Mar 31, 2023

Description of your changes

Previous vela cluster join --name <cluster-name> will report cluster already exist error when the target cluster already exists.

Now it will ask you if you would like to overwrite the old one or pass -y/--yes to overwrite it by default.

$ vela cluster join --name cluster-worker my.kubeconfig                                                                                                                                                            
Cluster already exists, do you want to overwrite it? (y/n)y
Successfully add cluster cluster-worker, endpoint: <endpoint>

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found 9 existing alerts. Please check the repository Security tab to see all alerts.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (784106c) 61.58% compared to head (401da87) 61.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5784      +/-   ##
==========================================
- Coverage   61.58%   61.56%   -0.03%     
==========================================
  Files         217      217              
  Lines       30694    30709      +15     
==========================================
+ Hits        18903    18906       +3     
- Misses      10051    10058       +7     
- Partials     1740     1745       +5     
Flag Coverage Δ
core-unittests 55.88% <0.00%> (+0.09%) ⬆️
e2e-multicluster-test 25.56% <50.00%> (-0.14%) ⬇️
e2e-rollout-tests 22.27% <0.00%> (-0.02%) ⬇️
e2etests 27.95% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/multicluster/cluster_management.go 38.36% <50.00%> (-0.74%) ⬇️

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@chivalryq chivalryq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@Somefive Somefive force-pushed the feat/cluster-join-support-overwrite branch from 52aeab1 to 401da87 Compare March 31, 2023 08:27
@FogDong FogDong merged commit d8f92e0 into kubevela:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants