Feat: add type filter option #5789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iyear <ljyngup@gmail.com>
iyear
requested review from
barnettZQG,
wonderflow,
leejanee,
Somefive,
jefree-cat and
FogDong
as code owners
|
You have successfully added a new Trivy configuration |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5789 +/- ##
==========================================
- Coverage 61.72% 61.65% -0.08%
==========================================
Files 217 217
Lines 30711 30711
==========================================
- Hits 18957 18934 -23
- Misses 10017 10034 +17
- Partials 1737 1743 +6
Flags with carried forward coverage won't be shown. Click here to find out more. see 12 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Somefive
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Part of #5364
cuegen previously ignored the generation of field and embedded struct by json tag, now we need type filter to ignore the generation of top struct. This will be used by provider-gen to filter out the required structs, such as
providers.Params[T]andproviders.Returns[T]I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Unit tests
Special notes for your reviewer