Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support config validation depends on CueX #5796

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

nuclearwu
Copy link
Contributor

@nuclearwu nuclearwu commented Apr 4, 2023

Signed-off-by: wuzhongjian wuzhongjian_yewu@cmss.chinamobile.com

Description of your changes

Fixes #5088

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@nuclearwu
Copy link
Contributor Author

nuclearwu commented Apr 4, 2023

@barnettZQG @Somefive please review

@nuclearwu nuclearwu changed the title feat: support config validation depends on CueX Feat: support config validation depends on CueX Apr 4, 2023
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@Somefive Somefive self-assigned this Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage: 58.15% and project coverage change: +6.02 🎉

Comparison is base (bfa5f4c) 55.73% compared to head (3beca0f) 61.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5796      +/-   ##
==========================================
+ Coverage   55.73%   61.76%   +6.02%     
==========================================
  Files         178      223      +45     
  Lines       27367    30977    +3610     
==========================================
+ Hits        15254    19132    +3878     
+ Misses      10596    10095     -501     
- Partials     1517     1750     +233     
Flag Coverage Δ
core-unittests 55.86% <59.40%> (+0.12%) ⬆️
e2e-multicluster-test 25.57% <0.00%> (?)
e2e-rollout-tests 21.61% <0.00%> (?)
e2etests 27.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cue/cuex/compiler.go 0.00% <0.00%> (ø)
pkg/utils/registries/options.go 0.00% <0.00%> (ø)
pkg/utils/registries/registry_helper.go 0.00% <0.00%> (ø)
pkg/config/factory.go 65.62% <33.33%> (+1.24%) ⬆️
pkg/utils/helm/helm_helper.go 45.30% <52.38%> (+0.53%) ⬆️
pkg/utils/helm/repo_index.go 64.70% <64.70%> (ø)
pkg/utils/registries/secret_authenticator.go 65.71% <65.71%> (ø)
pkg/cue/cuex/providers/config/config.go 100.00% <100.00%> (ø)

... and 122 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

pkg/cue/cuex/compiler.go Outdated Show resolved Hide resolved
pkg/config/factory.go Outdated Show resolved Hide resolved
pkg/config/factory.go Outdated Show resolved Hide resolved
pkg/config/factory.go Outdated Show resolved Hide resolved
pkg/utils/registries/secret_authenticator.go Outdated Show resolved Hide resolved
@Somefive Somefive removed their assignment Apr 6, 2023
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
Copy link
Collaborator

@Somefive Somefive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
pkg/config/factory.go Outdated Show resolved Hide resolved
Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
@nuclearwu
Copy link
Contributor Author

Copy link
Collaborator

@barnettZQG barnettZQG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nuclearwu
Copy link
Contributor Author

@FogDong

Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but we need to move the providers to pkg or re-structure the dir in the future.

@Somefive Somefive merged commit c007ad8 into kubevela:master Apr 12, 2023
25 of 26 checks passed
iyear pushed a commit to iyear/kubevela that referenced this pull request Apr 21, 2023
* Feat: support config validation depends on CueX

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>

* Feat: support config validation depends on CueX

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>

* Feat: support config validation depends on CueX

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>

* Feat: support config validation depends on CueX

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>

---------

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
iyear pushed a commit to iyear/kubevela that referenced this pull request Apr 21, 2023
* Feat: support config validation depends on CueX

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>

* Feat: support config validation depends on CueX

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>

* Feat: support config validation depends on CueX

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>

* Feat: support config validation depends on CueX

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>

---------

Signed-off-by: wuzhongjian <wuzhongjian_yewu@cmss.chinamobile.com>
@nuclearwu nuclearwu deleted the validation branch May 12, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]helm repository and image registry support authenticate registry with credential specified
5 participants