Feat: support vela def vet the input "dir" and many cue files #5806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mcduller <1596582524@qq.com>
Signed-off-by: Mcduller <1596582524@qq.com>
…vet_dir # Conflicts: # references/cli/test-data/defapply/testdef.cue
Mcduller
requested review from
Somefive,
StevenLeiZhang,
charlie0129,
chivalryq,
barnettZQG,
wonderflow,
leejanee,
jefree-cat and
FogDong
as code owners
|
You have successfully added a new Trivy configuration |
Mcduller
changed the title
Somefive
reviewed
Apr 6, 2023
references/cli/def.go
Outdated
| if err := def.FromCUEString(string(cueBytes), config); err != nil { | ||
| return errors.Wrapf(err, "failed to parse CUE") | ||
| for _, arg := range args { | ||
| files, err := utils.LoadDataFromPath(context.Background(), arg, utils.IsCUEFile) |
There was a problem hiding this comment.
context.Background() -> cmd.Context()
references/cli/def.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| streams.Infonln(validateRes) |
There was a problem hiding this comment.
We can use fmt.Fprintf(cmd.Stdout, "xxx") instead of streams.Infoln
…vet_dir Signed-off-by: Mcduller <1596582524@qq.com> # Conflicts: # references/cli/test-data/defapply/testdef.cue
…vet_dir Signed-off-by: Mcduller <1596582524@qq.com> # Conflicts: # references/cli/test-data/defapply/testdef.cue
charlie0129
reviewed
Apr 6, 2023
references/cli/def.go
Outdated
Comment on lines
1042
to
1049
| "> vela def vet my-def.cue\n" + | ||
| "# Command below will validate all the cue file\n" + | ||
| "> vela def vet my-def1.cue my-def2.cue my-def3.cue\n" + | ||
| "# Command below will validate all the cue in specific dir\n" + | ||
| "> vela def vet ./test/" + | ||
| "# Command below will validate all the cue files in all specific dirs" + | ||
| "> vela def vet ./test1/ ./test2/", | ||
| Args: cobra.MinimumNArgs(1), |
There was a problem hiding this comment.
Suggested change
| "> vela def vet my-def.cue\n" + | |
| "# Command below will validate all the cue file\n" + | |
| "> vela def vet my-def1.cue my-def2.cue my-def3.cue\n" + | |
| "# Command below will validate all the cue in specific dir\n" + | |
| "> vela def vet ./test/" + | |
| "# Command below will validate all the cue files in all specific dirs" + | |
| "> vela def vet ./test1/ ./test2/", | |
| Args: cobra.MinimumNArgs(1), | |
| "> vela def vet my-def.cue\n" + | |
| "# Validate every cue file provided\n" + | |
| "> vela def vet my-def1.cue my-def2.cue my-def3.cue\n" + | |
| "# Validate every cue file in the specified directories" + | |
| "> vela def vet ./test1/ ./test2/", | |
| Args: cobra.MinimumNArgs(1), |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5806 +/- ##
==========================================
- Coverage 61.65% 61.56% -0.10%
==========================================
Files 217 217
Lines 30711 30696 -15
==========================================
- Hits 18934 18897 -37
- Misses 10034 10050 +16
- Partials 1743 1749 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mcduller <1596582524@qq.com>
Signed-off-by: Mcduller <1596582524@qq.com>
Somefive
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #4744
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer