Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use step id to filter the log data and fix the regex #5809

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Apr 6, 2023

Description of your changes

Fix: use step id to filter the log data and fix the regex

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong added backport release-1.7 add this label will automatically backport this PR to release-1.7 branch backport release-1.8 add this label will automatically backport this PR to release-1.8 branch labels Apr 6, 2023
@github-advanced-security
Copy link

You have successfully added a new Trivy configuration .github/workflows/trivy-scan.yml:images. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -4.00 ⚠️

Comparison is base (3c2d47b) 61.64% compared to head (3080931) 57.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5809      +/-   ##
==========================================
- Coverage   61.64%   57.65%   -4.00%     
==========================================
  Files         217      212       -5     
  Lines       30694    30480     -214     
==========================================
- Hits        18922    17572    -1350     
- Misses      10031    11297    +1266     
+ Partials     1741     1611     -130     
Flag Coverage Δ
core-unittests 55.80% <ø> (-0.04%) ⬇️
e2e-multicluster-test ?
e2e-rollout-tests 22.30% <ø> (+<0.01%) ⬆️
e2etests 27.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 60 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit c128c71 into kubevela:master Apr 7, 2023
27 of 28 checks passed
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Successfully created backport PR for release-1.7:

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Successfully created backport PR for release-1.8:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.7 add this label will automatically backport this PR to release-1.7 branch backport release-1.8 add this label will automatically backport this PR to release-1.8 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants