Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add special field name test case #5826

Merged

Conversation

iyear
Copy link
Contributor

@iyear iyear commented Apr 10, 2023

Description of your changes

Part of #5364

Add a test case

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: iyear <ljyngup@gmail.com>
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (57dd6d1) 61.64% compared to head (28ab675) 61.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5826      +/-   ##
==========================================
- Coverage   61.64%   61.63%   -0.02%     
==========================================
  Files         217      217              
  Lines       30745    30745              
==========================================
- Hits        18954    18950       -4     
- Misses      10048    10049       +1     
- Partials     1743     1746       +3     
Flag Coverage Δ
core-unittests 55.83% <ø> (+0.01%) ⬆️
e2e-multicluster-test 25.66% <ø> (-0.13%) ⬇️
e2e-rollout-tests 22.26% <ø> (-0.06%) ⬇️
e2etests 28.15% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wonderflow wonderflow merged commit 6397f97 into kubevela:master Apr 11, 2023
25 of 26 checks passed
@Somefive Somefive mentioned this pull request Apr 19, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants