Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: migrate prism cluster #5836

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

Somefive
Copy link
Collaborator

Description of your changes

Migrate prism cluster to cluster-gateway to decouple kubevela/prism from this main repo.

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 70.58% and project coverage change: -0.13 ⚠️

Comparison is base (c007ad8) 61.64% compared to head (4225261) 61.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5836      +/-   ##
==========================================
- Coverage   61.64%   61.52%   -0.13%     
==========================================
  Files         223      223              
  Lines       30977    30979       +2     
==========================================
- Hits        19096    19059      -37     
- Misses      10122    10155      +33     
- Partials     1759     1765       +6     
Flag Coverage Δ
core-unittests 55.83% <31.25%> (+<0.01%) ⬆️
e2e-multicluster-test 25.32% <58.82%> (-0.30%) ⬇️
e2e-rollout-tests 21.61% <26.66%> (-0.02%) ⬇️
e2etests 27.32% <33.33%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cmd/completion.go 0.00% <0.00%> (ø)
pkg/multicluster/utils.go 60.22% <ø> (-0.45%) ⬇️
pkg/utils/common/common.go 59.06% <ø> (-0.14%) ⬇️
pkg/multicluster/cluster_management.go 35.62% <42.85%> (-2.74%) ⬇️
pkg/addon/addon.go 58.80% <100.00%> (ø)
pkg/multicluster/virtual_cluster.go 78.67% <100.00%> (-0.59%) ⬇️
pkg/policy/topology.go 90.62% <100.00%> (ø)

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@wonderflow wonderflow merged commit 792f33d into kubevela:master Apr 12, 2023
26 of 27 checks passed
iyear pushed a commit to iyear/kubevela that referenced this pull request Apr 21, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
iyear pushed a commit to iyear/kubevela that referenced this pull request Apr 21, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants