Feat: initial provider generator #5839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iyear
requested review from
barnettZQG,
wonderflow,
leejanee,
Somefive,
jefree-cat and
FogDong
as code owners
|
/cc @FogDong |
iyear
force-pushed
the
cuegen/initial-provider-gen
branch
from
64c56c3
to
3be88aa
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5839 +/- ##
==========================================
- Coverage 61.35% 61.28% -0.07%
==========================================
Files 224 224
Lines 31121 31121
==========================================
- Hits 19093 19073 -20
- Misses 10233 10254 +21
+ Partials 1795 1794 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
FogDong
reviewed
Apr 13, 2023
FogDong
reviewed
Apr 13, 2023
FogDong
reviewed
Apr 13, 2023
iyear
requested review from
chivalryq,
wangyikewxgm,
charlie0129 and
StevenLeiZhang
as code owners
iyear
force-pushed
the
cuegen/initial-provider-gen
branch
from
7e99262
to
cd627a0
Compare
Signed-off-by: iyear <ljyngup@gmail.com>
iyear
force-pushed
the
cuegen/initial-provider-gen
branch
from
cd627a0
to
cb6a900
Compare
Signed-off-by: iyear <ljyngup@gmail.com>
iyear
force-pushed
the
cuegen/initial-provider-gen
branch
from
cb6a900
to
140f8d8
Compare
FogDong
approved these changes
Apr 24, 2023
Somefive
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Part of #5364
This is initial impl of provider generator. The impl is a bit hacky currently and I will refactor it in the future. So it's helpful to just look into testings instead of impl code.
How it works:
map[string]github.com/kubevela/pkg/cue/cuex/runtime.ProviderFnin target go file.Format.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer