Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix terminate suspending steps #5872

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Apr 18, 2023

Description of your changes

🤖 Generated by Copilot at ecaa84c

Summary

🧪🛑🔄

This pull request enhances the TerminateWorkflow function to handle suspending workflow steps. It also updates the unit tests in operation_test.go to cover this new feature.

Oh we are the coders of the operation package
We write the tests to make our code more savage
We heave and we ho and we TerminateWorkflow
And we don't let the suspending steps slow us down

Walkthrough

  • Add a case for suspending workflow steps in TerminateWorkflow function (link, link)
  • Update existing test case for TerminateWorkflow function to match new logic (link)
  • Add a new test case for TerminateWorkflow function to cover suspending scenario (link)

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.01 🎉

Comparison is base (0e77b2b) 61.17% compared to head (ecaa84c) 61.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5872      +/-   ##
==========================================
+ Coverage   61.17%   61.18%   +0.01%     
==========================================
  Files         223      223              
  Lines       30980    30980              
==========================================
+ Hits        18951    18956       +5     
- Misses      10264    10265       +1     
+ Partials     1765     1759       -6     
Flag Coverage Δ
core-unittests 55.81% <50.00%> (+0.02%) ⬆️
e2e-multicluster-test 25.33% <0.00%> (+0.03%) ⬆️
e2etests 26.75% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/workflow/operation/operation.go 39.57% <50.00%> (+1.31%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FogDong FogDong added the backport release-1.8 add this label will automatically backport this PR to release-1.8 branch label Apr 18, 2023
@FogDong FogDong merged commit 657fcc6 into kubevela:master Apr 18, 2023
23 of 24 checks passed
@FogDong FogDong deleted the fix-terminate branch April 18, 2023 08:57
@github-actions
Copy link

Successfully created backport PR for release-1.8:

iyear pushed a commit to iyear/kubevela that referenced this pull request Apr 21, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
iyear pushed a commit to iyear/kubevela that referenced this pull request Apr 21, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Kolossi pushed a commit to Kolossi/kubevela that referenced this pull request Apr 24, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Signed-off-by: paul <paul@kolossi.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-1.8 add this label will automatically backport this PR to release-1.8 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants