Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support mark stage in gc when workflow failed #5882

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

Somefive
Copy link
Collaborator

Description of your changes

Refactor #5812

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.34 ⚠️

Comparison is base (feb8199) 61.39% compared to head (80dc218) 61.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5882      +/-   ##
==========================================
- Coverage   61.39%   61.05%   -0.34%     
==========================================
  Files         223      224       +1     
  Lines       30983    30994      +11     
==========================================
- Hits        19022    18924      -98     
- Misses      10187    10296     +109     
  Partials     1774     1774              
Flag Coverage Δ
core-unittests 55.85% <100.00%> (-0.03%) ⬇️
e2e-multicluster-test 24.90% <42.85%> (-0.15%) ⬇️
e2etests 26.71% <42.85%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dev/v1alpha2/application/application_controller.go 82.88% <100.00%> (ø)
pkg/resourcekeeper/context.go 100.00% <100.00%> (ø)
pkg/resourcekeeper/gc.go 78.96% <100.00%> (+0.37%) ⬆️

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive marked this pull request as ready for review April 19, 2023 09:52
@Somefive
Copy link
Collaborator Author

/cc @zxbyoyoyo

@Somefive Somefive merged commit 106b7b3 into kubevela:master Apr 20, 2023
22 of 23 checks passed
iyear pushed a commit to iyear/kubevela that referenced this pull request Apr 21, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
iyear pushed a commit to iyear/kubevela that referenced this pull request Apr 21, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Kolossi pushed a commit to Kolossi/kubevela that referenced this pull request Apr 24, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Signed-off-by: paul <paul@kolossi.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants