Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The addon page displays the deleted addon #5924

Merged
merged 3 commits into from
May 8, 2023
Merged

Fix: The addon page displays the deleted addon #5924

merged 3 commits into from
May 8, 2023

Conversation

suwliang3
Copy link
Contributor

Description of your changes

After you delete an addon from the addon repository, the addon management page shouldn't display the addon.

Fixes #5750

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 72.72% and project coverage change: -4.81 ⚠️

Comparison is base (9def408) 60.65% compared to head (4c0a2d7) 55.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5924      +/-   ##
==========================================
- Coverage   60.65%   55.85%   -4.81%     
==========================================
  Files         224      184      -40     
  Lines       31162    27819    -3343     
==========================================
- Hits        18900    15537    -3363     
- Misses      10488    10722     +234     
+ Partials     1774     1560     -214     
Flag Coverage Δ
core-unittests 55.85% <72.72%> (+0.01%) ⬆️
e2e-multicluster-test ?
e2etests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/cache.go 35.44% <72.72%> (+1.81%) ⬆️

... and 120 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
@suwliang3
Copy link
Contributor Author

@wonderflow load image failed

Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
pkg/addon/cache.go Outdated Show resolved Hide resolved
Co-authored-by: qiaozp <47812250+chivalryq@users.noreply.github.com>
Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
@chivalryq chivalryq merged commit c06c5dd into kubevela:master May 8, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] The addon management page displays the deleted addon
3 participants