Chore: upgrade ginkgo to v2 #5940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
chivalryq,
wonderflow,
FogDong,
wangyikewxgm,
charlie0129,
StevenLeiZhang,
leejanee,
barnettZQG and
jefree-cat
as code owners
Somefive
force-pushed
the
upgrade-ginkgo-v2
branch
2 times, most recently
from
f8024a0
to
d2e3fe2
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5940 +/- ##
==========================================
- Coverage 60.78% 60.68% -0.10%
==========================================
Files 224 224
Lines 31202 31202
==========================================
- Hits 18967 18936 -31
- Misses 10467 10488 +21
- Partials 1768 1778 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chivalryq
approved these changes
May 4, 2023
FogDong
approved these changes
May 5, 2023
Somefive
force-pushed
the
upgrade-ginkgo-v2
branch
3 times, most recently
from
f40a0b7
to
e0dda25
Compare
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
upgrade-ginkgo-v2
branch
from
e0dda25
to
c123ba7
Compare
wangyikewxgm
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Upgrade ginkgo to v2.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer