Fix: trait not added in Go SDK #5950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
chivalryq
requested review from
wonderflow,
Somefive,
FogDong and
wangyikewxgm
as code owners
chivalryq
added
the
backport release-1.8
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5950 +/- ##
==========================================
+ Coverage 55.83% 60.61% +4.77%
==========================================
Files 184 224 +40
Lines 27800 31183 +3383
==========================================
+ Hits 15522 18901 +3379
+ Misses 10725 10505 -220
- Partials 1553 1777 +224
Flags with carried forward coverage won't be shown. Click here to find out more.
β View full report in Codecov by Sentry. |
|
/retest e2e-multicluster-test |
|
/retest e2e-test |
wangyikewxgm
approved these changes
May 4, 2023
|
Successfully created backport PR for |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fix: traits is not added to component in Go SDK.
π€ Generated by Copilot at e9b1b63
Summary
ππ οΈπ§Ή
Fix a syntax error in
genDedicatedFuncthat prevented generating Go functions for dedicated traits. The error was caused by an extra closing parenthesis inpkg/definition/gen_sdk/go.go.Walkthrough
genDedicatedFuncfunction by removing extra closing parenthesis (link)Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer