Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: restrict the rules that automatically add topology strategy to ddons to be valid only for the yaml type #5957

Merged
merged 1 commit into from
May 6, 2023

Conversation

zhaohuiweixiao
Copy link
Contributor

@zhaohuiweixiao zhaohuiweixiao commented May 5, 2023

Description of your changes

Fixes #5932

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

vela addon enable rollout --version 1.3.1
vela addon enable rollout --version 1.3.2

Special notes for your reviewer

@wangyikewxgm

…ddons to be valid only for the yaml type

Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com>
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +3.71 🎉

Comparison is base (e828d3c) 56.88% compared to head (605dd03) 60.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5957      +/-   ##
==========================================
+ Coverage   56.88%   60.60%   +3.71%     
==========================================
  Files         219      224       +5     
  Lines       30973    31191     +218     
==========================================
+ Hits        17620    18902    +1282     
+ Misses      11710    10516    -1194     
- Partials     1643     1773     +130     
Flag Coverage Δ
core-unittests 55.78% <100.00%> (-0.10%) ⬇️
e2e-multicluster-test 24.74% <0.00%> (?)
e2etests 25.15% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/addon/render.go 67.70% <100.00%> (+0.40%) ⬆️

... and 57 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhaohuiweixiao
Copy link
Contributor Author

zhaohuiweixiao commented May 5, 2023

This change will affect addons that has not topology policy in template.cue file but runtimeClass is true. I've screened all the official addons, and found the kruise-rollout is only one of those cases. Also, the rollout and netlify addon has not template file, but their runtimeClass are runtime true, this is not a best pirice(We should always use templates of the cue type to define our addons, so that what you see is what you get for the addons). for resolve above, i have submmit a pr(https://github.com/kubevela/catalog/pull/684/files)

@Somefive Somefive merged commit 91e31c1 into kubevela:master May 6, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] A proposed change to automatically add topology policy rules to addon
3 participants