Fix: Restore service creation for gateway trait #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sweeney <psweeney@travelrepublic.co.uk>
Kolossi
requested review from
Somefive,
barnettZQG,
wonderflow,
FogDong,
wangyikewxgm,
chivalryq,
leejanee and
jefree-cat
as code owners
4 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5978 +/- ##
==========================================
- Coverage 60.55% 60.54% -0.02%
==========================================
Files 224 224
Lines 31202 31202
==========================================
- Hits 18895 18891 -4
- Misses 10525 10533 +8
+ Partials 1782 1778 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Somefive
approved these changes
May 12, 2023
|
/cc @chivalryq |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
🤖 Generated by Copilot at 9eb50ac
Summary
✨🔧📝
This pull request adds a new output to the gateway trait definition and template that creates a Service resource for the gateway. This enables users to specify custom domain names and use external DNS providers for the gateway.
Walkthrough
Restoring gateway trait service creation as per post-merge discussion on PR 5860
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Local dry-run and simple usage on a cluster.
Special notes for your reviewer
See #5860 (comment)