Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: CUE code quality changes #5987

Merged
merged 5 commits into from
May 15, 2023
Merged

Chore: CUE code quality changes #5987

merged 5 commits into from
May 15, 2023

Conversation

Ca-moes
Copy link
Contributor

@Ca-moes Ca-moes commented May 14, 2023

Small textual changes to CUE files for conformity across files.

🤖 Generated by Copilot at 0db49ac

Summary

📝📝🎨

This pull request improves the code quality and documentation of some internal trait and workflow step definitions in vela-templates. It fixes typos in the usage annotations of the labelSelector and forceDelete fields in topologySpreadConstraints and apply-terraform-config respectively, and adds blank lines for better readability in expose.

A typo was found in usage
It was spelled as usae by mistake
So they fixed it with care
In two places to spare
The confusion that it would create

Walkthrough

  • Add blank lines to improve readability of expose trait definition (link, link)
  • Fix typos in usage annotations of labelSelector and forceDelete fields in topologySpreadConstraints trait and apply-terraform-config workflow step (link, link)

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@Ca-moes Ca-moes changed the title Update apply-terraform-config.cue CUE: Code Quality changes May 14, 2023
@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -35.90 ⚠️

Comparison is base (d19bb89) 60.58% compared to head (ec443c1) 24.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5987       +/-   ##
===========================================
- Coverage   60.58%   24.69%   -35.90%     
===========================================
  Files         224      221        -3     
  Lines       31202    31067      -135     
===========================================
- Hits        18903     7671    -11232     
- Misses      10525    22337    +11812     
+ Partials     1774     1059      -715     
Flag Coverage Δ
core-unittests ?
e2e-multicluster-test 24.69% <ø> (-0.03%) ⬇️
e2etests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 160 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive changed the title CUE: Code Quality changes Chore: CUE code quality changes May 15, 2023
@Somefive
Copy link
Collaborator

Somefive commented May 15, 2023

Could you run make reviewable to format the related files generated by those CUE template?

BTW, please fix the DCO issue by signing your commit.

@Somefive Somefive added needs-format Pull request needs format. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 15, 2023
Ca-moes and others added 4 commits May 15, 2023 09:55
Update cue comment standard in one file

Signed-off-by: André Gomes <andre3000pt@gmail.com>
Corrected cue format

Signed-off-by: André Gomes <andre3000pt@gmail.com>
Signed-off-by: André Gomes <andre3000pt@gmail.com>
usae -> usage

Signed-off-by: André Gomes <andre3000pt@gmail.com>
Signed-off-by: André Gomes <andre3000pt@gmail.com>
@Somefive Somefive merged commit 7b119e6 into kubevela:master May 15, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-format Pull request needs format. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants