Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: CUE code quality changes - line spaces and typos #5997

Merged
merged 1 commit into from
May 16, 2023

Conversation

Ca-moes
Copy link
Contributor

@Ca-moes Ca-moes commented May 15, 2023

Description of your changes

Added blank lines and fixed typo in .cue file.

🤖 Generated by Copilot at 71dbb7e

Summary

🐛📝🎨

Fix typo in annotations field of expose trait definition. This affects both the CUE file vela-templates/definitions/internal/trait/expose.cue and the Helm template charts/vela-core/templates/defwithtemplate/expose.yaml.

expose trait typo
fixed in template and CUE
autumn leaves no trace

Walkthrough

  • Fix typo in annotations field of expose trait definition (link, link)

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

I'm doing a parser for CUE in Python and these small changes help a lot, thank you for considering this tiny merge 💝

Signed-off-by: André Gomes <andre3000pt@gmail.com>
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.71 🎉

Comparison is base (31a0158) 55.96% compared to head (71dbb7e) 60.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5997      +/-   ##
==========================================
+ Coverage   55.96%   60.68%   +4.71%     
==========================================
  Files         184      224      +40     
  Lines       27819    31202    +3383     
==========================================
+ Hits        15569    18935    +3366     
+ Misses      10687    10490     -197     
- Partials     1563     1777     +214     
Flag Coverage Δ
core-unittests 55.95% <ø> (-0.01%) ⬇️
e2e-multicluster-test 24.70% <ø> (?)
e2etests 25.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 120 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit fb53904 into kubevela:master May 16, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants