Feat: support remote cluster client to allow user use CRD resource in managed cluster without installing CRD to hub cluster #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
chivalryq,
wonderflow,
FogDong,
wangyikewxgm,
barnettZQG,
leejanee and
jefree-cat
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6008 +/- ##
==========================================
- Coverage 60.98% 60.91% -0.07%
==========================================
Files 225 225
Lines 31345 31345
==========================================
- Hits 19116 19095 -21
- Misses 10458 10473 +15
- Partials 1771 1777 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Somefive
force-pushed
the
feat/support-remote-cluster-client
branch
6 times, most recently
from
9792fc9
to
1464ff8
Compare
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
feat/support-remote-cluster-client
branch
from
1464ff8
to
b80b375
Compare
Somefive
changed the title
chivalryq
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #5973
Depends on kubevela/pkg#83
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer