-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: set CLI verbose output to be hidden by default #6016
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6016 +/- ##
==========================================
+ Coverage 60.12% 60.98% +0.85%
==========================================
Files 225 225
Lines 31349 31349
==========================================
+ Hits 18849 19118 +269
+ Misses 10706 10461 -245
+ Partials 1794 1770 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Consider add a short version. Say |
The "-v" is used by some commands, like vela install. Upper case is okay for me, but not aligned with the |
e29b83d
to
f1f516d
Compare
|
This is how "KinD" use the flag.
This is k3d
This is kubectl.
So, if we would like to use the verbose level, I think It you prefer @wonderflow @FogDong WDYT |
Great, verbosity +1, suppurt |
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
f1f516d
to
625d6a8
Compare
Done |
Description of your changes
Add "--verbosity"/"-V" global flag for vela cli. By default 0.
When 0, all "klog.Info" will be omitted. "klog.Error" will be written to stderr.
When greater than 0, "klog.Info" will be written to stdout.
When greater than 3, the call file and time will be printed.
When greater than 6, all details will be printed.
Fixes #5561
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer