Feat: expose probe params in helm chart #6044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyzxw
requested review from
barnettZQG,
wonderflow,
leejanee,
Somefive,
jefree-cat,
FogDong,
wangyikewxgm and
chivalryq
as code owners
yyzxw
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6044 +/- ##
==========================================
- Coverage 61.08% 61.07% -0.01%
==========================================
Files 224 225 +1
Lines 31304 31349 +45
==========================================
+ Hits 19121 19147 +26
- Misses 10415 10434 +19
Partials 1768 1768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/retest go |
Somefive
reviewed
May 29, 2023
yyzxw
force-pushed
the
feature/chart-add-probe
branch
from
cc00aa2
to
1b827c2
Compare
|
Seems some problems with the helm chart parameter. |
Signed-off-by: yyzxw <1020938856@qq.com>
yyzxw
force-pushed
the
feature/chart-add-probe
branch
from
1b827c2
to
42af8e9
Compare
|
/retest go |
Somefive
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
🤖 Generated by Copilot at cc00aa2
Summary
📝🛠️🎛️
This pull request updates the
vela-corehelm chart to support configuration options for the controller's readiness and liveness probes. It modifies theREADME.md,kubevela-controller.yaml, andvalues.yamlfiles to document, use, and define the new parameters.Walkthrough
README.mdto document the new parameters in theCommon parameterssection (link)kubevela-controller.yamltemplate to use the values fromcontroller.readinessProbeandcontroller.livenessProbeinstead of hard-coded values (link)values.yamlfile (link)expose readiness & liveness probe params in values.yaml so that users can customize the probe configuration.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer