Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ignore kind not match err for vela def #6053

Merged
merged 1 commit into from
May 30, 2023

Conversation

Somefive
Copy link
Collaborator

Description of your changes

The ScopeDefinition CRD is removed from the chart in v1.9.0 but it will report kind not found error for vela def command as it will search all the possible XXXDefinition when not specified. This will break when the ScopeDefinition CRD is not installed in the cluster. This PR fixes it.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.95 🎉

Comparison is base (8818f54) 60.12% compared to head (798c301) 61.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6053      +/-   ##
==========================================
+ Coverage   60.12%   61.08%   +0.95%     
==========================================
  Files         225      225              
  Lines       31349    31350       +1     
==========================================
+ Hits        18849    19150     +301     
+ Misses      10706    10430     -276     
+ Partials     1794     1770      -24     
Flag Coverage Δ
core-unittests 56.25% <0.00%> (+<0.01%) ⬆️
e2e-multicluster-test 25.08% <0.00%> (+0.01%) ⬆️
e2etests 25.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/definition/definition.go 72.31% <0.00%> (-0.17%) ⬇️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chivalryq chivalryq merged commit ff881f9 into kubevela:master May 30, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants