Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: component-pod-view not showing podIP, hostIP, nodeName #6058

Merged
merged 1 commit into from
May 31, 2023

Conversation

chivalryq
Copy link
Member

@chivalryq chivalryq commented May 31, 2023

Description of your changes

πŸ€– Generated by Copilot at 9a69fe8

Summary

πŸ›πŸ› οΈπŸ§ͺ

Fix bug in velaql component-pod template to include podIP, hostIP, and nodeName fields. Enhance velaql feature and add more tests.

velaql bug fixed
pod fields now show correctly
autumn of testing

Walkthrough

  • Fix bug in velaql component-pod template to include podIP, hostIP, and nodeName fields in output (link)

Fixes #6054

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: Qiaozp <qiaozhongpei.qzp@alibaba-inc.com>
@chivalryq chivalryq added the backport release-1.8 add this label will automatically backport this PR to release-1.8 branch label May 31, 2023
@Somefive Somefive removed the backport release-1.8 add this label will automatically backport this PR to release-1.8 branch label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +4.01 πŸŽ‰

Comparison is base (1c0f2c4) 57.16% compared to head (9a69fe8) 61.18%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6058      +/-   ##
==========================================
+ Coverage   57.16%   61.18%   +4.01%     
==========================================
  Files         220      225       +5     
  Lines       31136    31350     +214     
==========================================
+ Hits        17800    19182    +1382     
+ Misses      11695    10410    -1285     
- Partials     1641     1758     +117     
Flag Coverage Ξ”
core-unittests 56.25% <ΓΈ> (+<0.01%) ⬆️
e2e-multicluster-test 25.17% <ΓΈ> (?)
e2etests 25.13% <ΓΈ> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 62 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@chivalryq
Copy link
Member Author

/retest e2e-test

@Somefive Somefive merged commit c039328 into kubevela:master May 31, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to return the PodIP When using VelaQL component-pod-view in vela 1.8
2 participants