-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: parallel init cluster info #6060
Merged
Somefive
merged 1 commit into
kubevela:master
from
yyzxw:feature/enable-parall-init-cluster
May 31, 2023
Merged
Feat: parallel init cluster info #6060
Somefive
merged 1 commit into
kubevela:master
from
yyzxw:feature/enable-parall-init-cluster
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyzxw
requested review from
barnettZQG,
wonderflow,
leejanee,
Somefive,
jefree-cat,
FogDong,
wangyikewxgm and
chivalryq
as code owners
May 31, 2023 07:28
yyzxw
changed the title
feature: parallel init cluster info
Feat: parallel init cluster info
May 31, 2023
Somefive
reviewed
May 31, 2023
yyzxw
force-pushed
the
feature/enable-parall-init-cluster
branch
from
May 31, 2023 07:40
b5ef09e
to
fc8bd38
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6060 +/- ##
==========================================
- Coverage 61.00% 60.97% -0.03%
==========================================
Files 224 224
Lines 31274 31274
==========================================
- Hits 19079 19070 -9
- Misses 10430 10432 +2
- Partials 1765 1772 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Somefive
reviewed
May 31, 2023
yyzxw
force-pushed
the
feature/enable-parall-init-cluster
branch
from
May 31, 2023 09:51
fc8bd38
to
49ecfdf
Compare
Somefive
reviewed
May 31, 2023
Signed-off-by: yyzxw <1020938856@qq.com>
yyzxw
force-pushed
the
feature/enable-parall-init-cluster
branch
from
May 31, 2023 11:05
49ecfdf
to
cfe48ff
Compare
/retest go |
Somefive
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
🤖 Generated by Copilot at b5ef09e
Summary
🚀🙌🔗
Improve multicluster initialization performance and error handling by using
errgroup
to parallelize cluster version queries invirtual_cluster.go
.Walkthrough
errgroup.Group
([link](https://github.com/kubevela/kubevela/pull/6060/files?diff=unified&w=0#diff-3b863babb08434dd0a998f7b6f89e87f139420f288089d65b778e67595259cb8R25-R26)
,[link](https://github.com/kubevela/kubevela/pull/6060/files?diff=unified&w=0#diff-3b863babb08434dd0a998f7b6f89e87f139420f288089d65b778e67595259cb8L65-R78)
)In my case, if there are a lot of virtual clusters (secrets), but their corresponding clusters are temporarily disconnected, this will eventually cause the context to time out, and the requests will accumulate, causing the controller to take a long time to restart, This causes the controller to be rebooted frequently because the ready probe is not satisfied. Therefore, cluster information is initialized in parallel to accelerate the startup speed of controller.
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer