Fix: vela def vet can be used without Kubernetes #6063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
requested review from
wangyikewxgm,
wonderflow,
charlie0129,
StevenLeiZhang,
chivalryq,
barnettZQG,
leejanee,
jefree-cat and
FogDong
as code owners
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6063 +/- ##
==========================================
- Coverage 66.21% 66.06% -0.15%
==========================================
Files 193 193
Lines 25123 25127 +4
==========================================
- Hits 16635 16600 -35
- Misses 6878 6912 +34
- Partials 1610 1615 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FogDong
approved these changes
Jun 1, 2023
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Somefive
force-pushed
the
fix/vela-def-decouple-k8s
branch
from
5779b59
to
ffd749d
Compare
wonderflow
reviewed
Jun 1, 2023
| @@ -772,7 +773,7 @@ func NewDefinitionRenderCommand(c common.Args) *cobra.Command { | |||
| } | |||
| config, err := c.GetConfig() | |||
| if err != nil { | |||
| return err | |||
| klog.Infof("ignore kubernetes cluster, unable to get kubeconfig: %s", err.Error()) | |||
There was a problem hiding this comment.
which parts of feature in this command rely on this config?
There was a problem hiding this comment.
So it is due to the usage of legacy PackageDiscover. But it is actually not working now so the config is not required. We will remove it entirely in #6031
chivalryq
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
vela def vetshould not need Kubernetes environment to run. This is useful because CUE community can therefore run CI without KinD or KubeBuilder in their docker container to verify if the version upgrade of CUE won't break the usage of KubeVela.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer