Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove legacy rollout and scope #6068

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Jun 1, 2023

Description of your changes

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@Somefive Somefive marked this pull request as draft June 1, 2023 03:11
@Somefive Somefive force-pushed the chore/remove-legacy-rollout branch from c7a6494 to 3ccf40d Compare June 1, 2023 03:23
@Somefive Somefive changed the title Chore: remove legacy rollout Chore: remove legacy rollout and scope Jun 1, 2023
@Somefive Somefive force-pushed the chore/remove-legacy-rollout branch from 3ccf40d to 2768422 Compare June 1, 2023 03:25
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.25 🎉

Comparison is base (1a6dafa) 65.99% compared to head (846490a) 66.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6068      +/-   ##
==========================================
+ Coverage   65.99%   66.25%   +0.25%     
==========================================
  Files         193      191       -2     
  Lines       25127    24660     -467     
==========================================
- Hits        16583    16338     -245     
+ Misses       6930     6725     -205     
+ Partials     1614     1597      -17     
Flag Coverage Δ
core-unittests 55.04% <66.66%> (+0.13%) ⬆️
e2e-multicluster-test 30.92% <61.53%> (+0.24%) ⬆️
e2etests 33.68% <61.53%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/core/app/options/options.go 92.45% <ø> (-0.34%) ⬇️
cmd/core/app/server.go 61.38% <ø> (-0.38%) ⬇️
pkg/appfile/appfile.go 69.83% <ø> (+0.86%) ⬆️
pkg/appfile/parser.go 73.26% <ø> (+1.79%) ⬆️
pkg/appfile/template.go 57.58% <ø> (+3.88%) ⬆️
...g/controller/core.oam.dev/oamruntime_controller.go 100.00% <ø> (ø)
....dev/v1beta1/application/application_controller.go 82.80% <ø> (-1.07%) ⬇️
...ntroller/core.oam.dev/v1beta1/application/apply.go 85.95% <ø> (+4.58%) ⬆️
...re.oam.dev/v1beta1/application/assemble/options.go 84.90% <ø> (+10.86%) ⬆️
...oller/core.oam.dev/v1beta1/application/revision.go 68.83% <ø> (+1.91%) ⬆️
... and 8 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive force-pushed the chore/remove-legacy-rollout branch from 2768422 to 25a2715 Compare June 1, 2023 03:51
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@Somefive Somefive force-pushed the chore/remove-legacy-rollout branch from 25a2715 to 78fbd4d Compare June 1, 2023 06:01
@Somefive Somefive marked this pull request as ready for review June 1, 2023 08:10
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@Somefive Somefive force-pushed the chore/remove-legacy-rollout branch from b3dc27d to 0ff3fbf Compare June 1, 2023 09:39
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@FogDong FogDong merged commit f15eba2 into kubevela:master Jun 5, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants