Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: addon status list addon info error when there are mulitiple registries #6073

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

zhaohuiweixiao
Copy link
Contributor

@zhaohuiweixiao zhaohuiweixiao commented Jun 2, 2023

Description of your changes

πŸ€– Generated by Copilot at 4456bd3

Summary

βœ¨πŸ›πŸ”

This pull request enhances the addon installation feature by assigning and using the registry name of the addon. This allows the UI to show the correct addon information and the CLI to find the compatible addon package. The changes affect the files pkg/addon/source.go and references/cli/addon.go.

addon gets a name
to show in web console
autumn leaves fall

Walkthrough

  • Assign registry name to addon object for UI data (link)
  • Find matching addon package from installed registry (link)

Fixes #6072

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

  1. add zhh-repo2 registry
  2. modify fluxcd addon parameter: add a deployGroup argument
  3. push the new fluxcd to zhh-repo2
  4. vela addon enable fluxcd from the zhh-repo2
  5. vela addon status fluxcd -v

Special notes for your reviewer

@wangyikewxgm

…stries

Signed-off-by: zhaohuihui <zhaohuihui_yewu@cmss.chinamobile.com>
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -35.34 ⚠️

Comparison is base (eb4b1a8) 66.00% compared to head (4456bd3) 30.67%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6073       +/-   ##
===========================================
- Coverage   66.00%   30.67%   -35.34%     
===========================================
  Files         193      190        -3     
  Lines       25127    24998      -129     
===========================================
- Hits        16586     7667     -8919     
- Misses       6923    16277     +9354     
+ Partials     1618     1054      -564     
Flag Coverage Ξ”
core-unittests ?
e2e-multicluster-test 30.67% <0.00%> (-0.02%) ⬇️
e2etests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
pkg/addon/source.go 0.00% <0.00%> (-51.67%) ⬇️

... and 141 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive added the lgtm Pull request looks good. label Jun 6, 2023
@wangyikewxgm wangyikewxgm merged commit 95fa621 into kubevela:master Jun 13, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Pull request looks good.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addon status list addon info error when there are mulitiple registries
4 participants