-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: remove schematic kube and helm #6099
Chore: remove schematic kube and helm #6099
Conversation
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6099 +/- ##
==========================================
+ Coverage 66.46% 66.47% +0.01%
==========================================
Files 191 184 -7
Lines 24780 24016 -764
==========================================
- Hits 16469 15965 -504
+ Misses 6711 6488 -223
+ Partials 1600 1563 -37
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
a17a6ca
to
a6cb05e
Compare
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
a6cb05e
to
1514a58
Compare
|
||
package utils | ||
|
||
import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing the whole pprof module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it changes to use https://github.com/kubevela/pkg/tree/main/util/profiling
Description of your changes
Continue #6095
Progress on #5702
🤖 Generated by Copilot at a17a6ca
Summary
🗑️🛠️📊
This pull request simplifies the core APIs and CRDs by removing unused or deprecated types, fields, and imports. It also adds a profiling server option to the core component and moves a type from
apis
tocli
package.Walkthrough
Kube
andKubeParameter
types and their methods fromcommon
package and updateSchematic
type to only includeCUE
andTerraform
fields (link, link, link, link, link)WorkflowState
type and its constants fromcommon
package and move them tovela-system
package (link)RawComponent
type fromcommon
package (link)Helm
type and its methods fromcommon
package (link, link)Status
field and its methods fromResourceTracker
type inv1beta1
package and change the receivers of other methods from value to pointer (link, link, link, link, link, link, link, link, link)addClusterObjectReference
andAddTrackedResource
methods fromResourceTracker
type inv1beta1
package (link)github.com/oam-dev/kubevela/apis/interfaces
import fromv1beta1
package (link)HelmCategory
andKubeCategory
constants andSetFlagBy
function fromtypes
package (link, link)KubeTemplate
andKubeParameter
fields fromCapability
type intypes
package (link)github.com/oam-dev/kubevela/pkg/utils
import fromapp
package (link)github.com/coreos/prometheus-operator
import fromgo.mod
(link)helm
andkube
fields from theoutput
andoutputs
schemas of theApplicationRevision
CRD incharts/vela-core/crds/core.oam.dev_applicationrevisions.yaml
(link, link, link, link, link)helm
andkube
fields from theschematic
schema of theComponentDefinition
,DefinitionRevision
,PolicyDefinition
,ResourceTracker
,TraitDefinition
, andWorkflowStepDefinition
CRDs incharts/vela-core/crds
(link, link, link, link, link, link, link, link, link)PprofAddr
flag with profiling server flag inoptions
package and updateCoreOptions
type and its methods accordingly (link, link, link, link, link, link, link)run
function inapp
package (link, link)RegistryConfig
type to usecli
package instead ofapis
package ine2e
package and update the import accordingly (link, link)apis/interfaces/resourcetracker.go
file as it was no longer used by the core logic (link)apis/types/workflow.go
file as it was no longer used by the core logic (link)Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer