Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove useless envbinding env #6122

Merged

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Jun 14, 2023

Description of your changes

The "env" parameter for envbinding is not used as the envbinding is deprecated for a while and removed in this version.

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 82.35% and no project coverage change.

Comparison is base (b05ea09) 66.32% compared to head (7ab795e) 66.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6122   +/-   ##
=======================================
  Coverage   66.32%   66.33%           
=======================================
  Files         184      184           
  Lines       24017    24029   +12     
=======================================
+ Hits        15929    15939   +10     
- Misses       6520     6521    +1     
- Partials     1568     1569    +1     
Flag Coverage Δ
core-unittests 55.52% <70.58%> (+0.01%) ⬆️
e2e-multicluster-test 31.00% <64.70%> (-0.03%) ⬇️
e2etests 32.60% <64.70%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/workflow/providers/oam/apply.go 57.96% <62.50%> (-1.05%) ⬇️
...ller/core.oam.dev/v1beta1/application/generator.go 83.95% <100.00%> (+1.10%) ⬆️
pkg/workflow/providers/multicluster/deploy.go 74.19% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive force-pushed the chore/remove-useless-envbinding-env branch from 34e8343 to 672de5c Compare June 15, 2023 01:49
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@Somefive Somefive force-pushed the chore/remove-useless-envbinding-env branch from 672de5c to b82b366 Compare June 15, 2023 02:11
Signed-off-by: Somefive <yd219913@alibaba-inc.com>
@Somefive Somefive merged commit da3618a into kubevela:master Jun 15, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants