Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add an annotation for the addon #6256

Merged
merged 1 commit into from Aug 22, 2023
Merged

Conversation

suwliang3
Copy link
Contributor

@suwliang3 suwliang3 commented Aug 11, 2023

Description of your changes

🤖 Generated by Copilot at 0c1b191

Summary

🏷️🧩🚀

Add a new annotation system.addon to helm charts of addons in the addon package. This enables the system to recognize and handle addons differently from regular helm charts.

addon package grows
adding annotation key
system.addon - spring

Walkthrough

  • Add system.addon annotation to helm chart metadata of addons (link)
    • Use the constant addonSystemRequirement from the addon package as the annotation key (link)
  • Define the constant addonSystemRequirement in the addon package (link)
    • The constant is used in the utils.go file to add the annotation to addons (link)

Fixes #6255

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (9c57c09) 66.30% compared to head (5e0ac1d) 66.26%.

❗ Current head 5e0ac1d differs from pull request most recent head 827e535. Consider uploading reports for the commit 827e535 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6256      +/-   ##
==========================================
- Coverage   66.30%   66.26%   -0.05%     
==========================================
  Files         183      183              
  Lines       23950    23951       +1     
==========================================
- Hits        15880    15870      -10     
- Misses       6509     6523      +14     
+ Partials     1561     1558       -3     
Flag Coverage Δ
core-unittests 55.29% <100.00%> (+0.01%) ⬆️
e2e-multicluster-test 31.00% <0.00%> (-0.12%) ⬇️
e2etests 32.91% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/addon/versioned_registry.go 80.11% <ø> (ø)
pkg/addon/utils.go 68.66% <100.00%> (+0.94%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@suwliang3 suwliang3 changed the title feature: add an annotation for the addon Feat: add an annotation for the addon Aug 11, 2023
Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, please add some test cases

Signed-off-by: suwanliang_yewu <suwanliang_yewu@cmss.chinamobile.com>
@wangyikewxgm wangyikewxgm merged commit 88a85ea into kubevela:master Aug 22, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] add an annotation key to identity an addon from helm chart structure
3 participants