-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(CUE): fix variable error bug in startup-probe #6472
Conversation
The original variable is "grtcpSocketpc", but this variable does not exist in the file. According to the context, it should be "tcpSocket". In addition, its type needs to be int to work properly. Signed-off-by: zengziheng <zengziheng@datacloak.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6472 +/- ##
===========================================
- Coverage 65.54% 31.10% -34.44%
===========================================
Files 183 181 -2
Lines 23891 23849 -42
===========================================
- Hits 15659 7418 -8241
- Misses 6648 15410 +8762
+ Partials 1584 1021 -563
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. Please sign the dco and run make reviewable
, this command will generate the yaml based on cue automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please sign the DCO
I have signed the DCO😀 |
hi there, just a friendly reminder to merge my PR when you get a chance. Please let me know if there are any other issues or feedback you'd like me to address. Thank you!😀 |
I received a notification that a certain workflow failed to run. Is there any problem? |
The original variable is "grtcpSocketpc", but this variable does not exist in the file. According to the context, it should be "tcpSocket". In addition, its type needs to be int to work properly.
Description of your changes
copilot:all
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Special notes for your reviewer