Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(CUE): fix variable error bug in startup-probe #6472

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

codeReaper2001
Copy link
Contributor

@codeReaper2001 codeReaper2001 commented Mar 9, 2024

The original variable is "grtcpSocketpc", but this variable does not exist in the file. According to the context, it should be "tcpSocket". In addition, its type needs to be int to work properly.

Description of your changes

copilot:all

Fixes #

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

The original variable is "grtcpSocketpc", but this variable does not
exist in the file. According to the context, it should be "tcpSocket".
In addition, its type needs to be int to work properly.

Signed-off-by: zengziheng <zengziheng@datacloak.com>
Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.10%. Comparing base (1a001e5) to head (6ac92d4).
Report is 5 commits behind head on master.

❗ Current head 6ac92d4 differs from pull request most recent head fd5bb59. Consider uploading reports for the commit fd5bb59 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6472       +/-   ##
===========================================
- Coverage   65.54%   31.10%   -34.44%     
===========================================
  Files         183      181        -2     
  Lines       23891    23849       -42     
===========================================
- Hits        15659     7418     -8241     
- Misses       6648    15410     +8762     
+ Partials     1584     1021      -563     
Flag Coverage Δ
core-unittests ?
e2e-multicluster-test 31.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Please sign the dco and run make reviewable, this command will generate the yaml based on cue automatically.

Copy link
Collaborator

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sign the DCO

@codeReaper2001
Copy link
Contributor Author

please sign the DCO

I have signed the DCO😀

@codeReaper2001
Copy link
Contributor Author

please sign the DCO

hi there, just a friendly reminder to merge my PR when you get a chance. Please let me know if there are any other issues or feedback you'd like me to address. Thank you!😀

@codeReaper2001
Copy link
Contributor Author

codeReaper2001 commented Mar 23, 2024

I received a notification that a certain workflow failed to run. Is there any problem?

@wonderflow wonderflow merged commit f46bfcf into kubevela:master Apr 7, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants