Fix: allow different service and container port #6477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
copilot:all
This PR allows specifying a different port and containerPort to be used by the service created by a webservice component.
It also allows the gateway trait to use an existing service (in the usecase, the one created by the webservice) rather than creating one.
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
I've used this locally, and have taken care that this is a non-breaking change is new properties are not used.
Special notes for your reviewer
An example usecase is a dotnet workload in the webservice container where dotnet serves on port 5000, but the service is to be exposed for port 80 requests. Currently there is no way to achieve this with the standard component/traits.