Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add get id in monitor context #13

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Oct 17, 2022

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 90.88% // Head: 90.90% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (302624c) compared to base (351ed4d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   90.88%   90.90%   +0.02%     
==========================================
  Files          14       15       +1     
  Lines         351      352       +1     
==========================================
+ Hits          319      320       +1     
  Misses         19       19              
  Partials       13       13              
Flag Coverage Δ
unit-test 90.90% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
monitor/context/context.go 100.00% <100.00%> (ø)
util/rand/strings.go 100.00% <0.00%> (ø)
controller/client/monitor_client.go 100.00% <0.00%> (ø)
multicluster/utils.go 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit 26e5042 into kubevela:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants