Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add kube.apply and fix cuex.withExtraData #43

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Feb 3, 2023

Signed-off-by: FogDong dongtianxin.tx@alibaba-inc.com

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 90.66% // Head: 90.23% // Decreases project coverage by -0.43% ⚠️

Coverage data is based on head (0f392f8) compared to base (eab57c8).
Patch coverage: 75.86% of modified lines in pull request are covered.

❗ Current head 0f392f8 differs from pull request most recent head 033159e. Consider uploading reports for the commit 033159e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   90.66%   90.23%   -0.43%     
==========================================
  Files          52       52              
  Lines        1682     1721      +39     
==========================================
+ Hits         1525     1553      +28     
- Misses        113      121       +8     
- Partials       44       47       +3     
Flag Coverage Δ
unit-test 90.23% <75.86%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cue/cuex/compiler.go 82.90% <68.75%> (-1.58%) ⬇️
cue/cuex/providers/kube/kube.go 85.88% <78.57%> (-7.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

cue/cuex/compiler.go Outdated Show resolved Hide resolved
@FogDong FogDong force-pushed the feat-apply branch 2 times, most recently from 85ea91c to 0f392f8 Compare February 6, 2023 02:20
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@Somefive Somefive merged commit ac89a08 into kubevela:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants