Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support cue printer & add support for protocol https #55

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

Somefive
Copy link
Collaborator

@Somefive Somefive commented Feb 21, 2023

  1. External provider use $params as input and $returns as output.
  2. Support https protocol for external provider. By default, it will use insecure-skip-verify.
  3. Split cue printer into separate functions.
  4. Update CI bootstrap to allow absolute crd path.
  5. External provider will inject "#do" value to http request header "CueX-External-Provider-Function".

@Somefive Somefive force-pushed the feat/cue-printer branch 3 times, most recently from 8ec1fdd to 679ef7e Compare February 22, 2023 02:29
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 90.06% // Head: 90.14% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (aebb253) compared to base (1ab9b99).
Patch coverage: 93.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   90.06%   90.14%   +0.08%     
==========================================
  Files          58       59       +1     
  Lines        1952     1989      +37     
==========================================
+ Hits         1758     1793      +35     
- Misses        142      143       +1     
- Partials       52       53       +1     
Flag Coverage Δ
unit-test 90.14% <93.22%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cue/util/printer.go 90.32% <90.32%> (ø)
cue/server/server.go 90.00% <90.90%> (+1.11%) ⬆️
cue/cuex/compiler.go 83.05% <100.00%> (+0.14%) ⬆️
cue/cuex/runtime/package.go 79.54% <100.00%> (+0.97%) ⬆️
cue/cuex/runtime/provider.go 88.67% <100.00%> (+2.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

… call with subpath

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@FogDong FogDong merged commit 3db6aa6 into kubevela:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants