Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: use endpoint path instead of using header for routing external … #56

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

Somefive
Copy link
Collaborator

…provider fn

…provider fn

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 90.14% // Head: 90.04% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (a7049f5) compared to base (3db6aa6).
Patch coverage: 87.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   90.14%   90.04%   -0.11%     
==========================================
  Files          59       60       +1     
  Lines        1989     2049      +60     
==========================================
+ Hits         1793     1845      +52     
- Misses        143      149       +6     
- Partials       53       55       +2     
Flag Coverage Δ
unit-test 90.04% <87.09%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cue/cuex/externalserver/server.go 86.66% <86.66%> (ø)
cue/cuex/runtime/provider.go 88.67% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@Somefive Somefive merged commit fc49c73 into kubevela:main Feb 23, 2023
@Somefive Somefive deleted the feat/ext-prd-endpoint branch February 23, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants