Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support get controller from context #57

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

Somefive
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 90.04% // Head: 89.95% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (a9528bd) compared to base (fc49c73).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   90.04%   89.95%   -0.10%     
==========================================
  Files          60       60              
  Lines        2049     2060      +11     
==========================================
+ Hits         1845     1853       +8     
- Misses        149      151       +2     
- Partials       55       56       +1     
Flag Coverage Δ
unit-test 89.95% <75.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/runtime/caller.go 64.70% <70.00%> (+7.56%) ⬆️
controller/client/monitor_client.go 100.00% <100.00%> (ø)
controller/reconciler/context.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive force-pushed the feat/caller branch 2 times, most recently from 8410d35 to aef151a Compare February 24, 2023 07:10
Signed-off-by: Yin Da <yd219913@alibaba-inc.com>
@Somefive Somefive merged commit 9ff31b2 into kubevela:main Feb 24, 2023
@Somefive Somefive deleted the feat/caller branch February 24, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants