Feat: add definition crd #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somefive
approved these changes
Mar 3, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 89.95% 89.96% +0.01%
==========================================
Files 60 61 +1
Lines 2060 2063 +3
==========================================
+ Hits 1853 1856 +3
Misses 151 151
Partials 56 56
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wonderflow
requested changes
Mar 3, 2023
Somefive
approved these changes
Mar 3, 2023
wonderflow
reviewed
Mar 3, 2023
wonderflow
reviewed
Mar 3, 2023
| - additionalPrinterColumns: | ||
| - jsonPath: .spec.type | ||
| name: TYPE | ||
| type: string |
There was a problem hiding this comment.
please also omit the timestamp.
There was a problem hiding this comment.
There is no timestamp in the spec, do you mean to omit the type?
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
wonderflow
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add definition crd. Currently only stores template and type in spec. In the long term, maybe we need to add verion in status.