Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add resource group in rules for compatibility #65

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Mar 16, 2023

No description provided.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong requested a review from Somefive as a code owner March 16, 2023 04:24
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: -0.26 ⚠️

Comparison is base (30767e9) 90.56% compared to head (929aec6) 90.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   90.56%   90.30%   -0.26%     
==========================================
  Files          64       64              
  Lines        2416     2445      +29     
==========================================
+ Hits         2188     2208      +20     
- Misses        166      172       +6     
- Partials       62       65       +3     
Flag Coverage Δ
unit-test 90.30% <92.85%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
util/k8s/resource.go 86.36% <76.92%> (-4.82%) ⬇️
util/resourcetopology/topology.go 92.78% <100.00%> (-1.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Somefive Somefive merged commit 6cc62fa into kubevela:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants